Remove CosmosDB database provider #8116

rynowak · 2024-12-10T22:15:09Z

Description

This is part of a refactor of the data layer to simplify the design. The CosmosDB implementation is complicated and unused so we're removing it.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

This is part of a refactor of the data layer to simplify the design. The CosmosDB implementation is complicated and unused so we're removing it. Signed-off-by: Ryan Nowak <[email protected]>

rynowak · 2024-12-10T22:15:45Z

cmd/applications-rp/radius-cloud.yaml

-  provider: "cosmosdb"
-  cosmosdb:
-    # Create your own SQL API Cosmos DB account and set url in this configuration or to RADIUS_STORAGEPROVIDER_COSMOSDB_URL environment variable
-    url: https://radius-eastus-test.documents.azure.com:443/


I thought it best to just remove this file. There's a bunch of Azure-specific stuff in here that's not relevant. I can't think of a scenario where this is used.

codecov · 2024-12-11T01:08:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (3a18b5a) to head (c4af6a9).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8116      +/-   ##
==========================================
+ Coverage   59.28%   59.66%   +0.37%     
==========================================
  Files         580      577       -3     
  Lines       38983    38573     -410     
==========================================
- Hits        23112    23013      -99     
+ Misses      14220    13914     -306     
+ Partials     1651     1646       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-12-11T17:25:21Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`f2aa80e`
Unique ID	func4d04e2fdf4
Image tag	pr-func4d04e2fdf4

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4d04e2fdf4
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4d04e2fdf4
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func4d04e2fdf4
controller test image location: ghcr.io/radius-project/dev/controller:pr-func4d04e2fdf4
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4d04e2fdf4
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
❌ ucp-cloud functional test failed. Please check the logs for more details
⌛ Starting ucp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details

radius-functional-tests · 2024-12-11T20:04:54Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`035b8c6`
Unique ID	funca21396b4d0
Image tag	pr-funca21396b4d0

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca21396b4d0
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca21396b4d0
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funca21396b4d0
controller test image location: ghcr.io/radius-project/dev/controller:pr-funca21396b4d0
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca21396b4d0
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-12-11T23:37:24Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`4c26d7c`
Unique ID	func1aba2be24c
Image tag	pr-func1aba2be24c

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1aba2be24c
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1aba2be24c
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1aba2be24c
controller test image location: ghcr.io/radius-project/dev/controller:pr-func1aba2be24c
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1aba2be24c
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

kachawla · 2024-12-12T00:11:24Z

pkg/corerp/README.md


    ```
    curl --location --request GET 'http://localhost:8080/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/radius-test-rg/providers/Applications.Core/environments/?api-version=2023-10-01-preview'
    ```

-1. You should also be able to see all changes in Cosmos DB


nit: should we update this to point to etcd (and later to postgres once the work completes) instead of deleting?

There's no straightforward way to do this with etcd.

What do you think about making this part of the postgres work? @superbeeny and I talked about updating the dev instructions as part of that.

that sounds good

radius-functional-tests · 2024-12-12T05:42:51Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`51340e6`
Unique ID	func4cb3837f47
Image tag	pr-func4cb3837f47

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4cb3837f47
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4cb3837f47
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func4cb3837f47
controller test image location: ghcr.io/radius-project/dev/controller:pr-func4cb3837f47
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4cb3837f47
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-12-12T17:01:19Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`c4af6a9`
Unique ID	func6d156a360d
Image tag	pr-func6d156a360d

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func6d156a360d
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func6d156a360d
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func6d156a360d
controller test image location: ghcr.io/radius-project/dev/controller:pr-func6d156a360d
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func6d156a360d
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Remove CosmosDB database provider

aa1a005

This is part of a refactor of the data layer to simplify the design. The CosmosDB implementation is complicated and unused so we're removing it. Signed-off-by: Ryan Nowak <[email protected]>

rynowak requested review from a team as code owners December 10, 2024 22:15

rynowak temporarily deployed to publish-bicep December 10, 2024 22:15 — with GitHub Actions Inactive

rynowak commented Dec 10, 2024

View reviewed changes

Merge branch 'main' into rynowak/remove-cosmos

f2aa80e

rynowak temporarily deployed to publish-bicep December 11, 2024 17:24 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests December 11, 2024 17:24 — with GitHub Actions Inactive

Merge branch 'main' into rynowak/remove-cosmos

035b8c6

ytimocin temporarily deployed to publish-bicep December 11, 2024 20:03 — with GitHub Actions Inactive

ytimocin temporarily deployed to functional-tests December 11, 2024 20:03 — with GitHub Actions Inactive

ytimocin approved these changes Dec 11, 2024

View reviewed changes

lakshmimsft approved these changes Dec 11, 2024

View reviewed changes

Merge branch 'main' into rynowak/remove-cosmos

4c26d7c

rynowak temporarily deployed to publish-bicep December 11, 2024 23:21 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests December 11, 2024 23:36 — with GitHub Actions Inactive

kachawla reviewed Dec 12, 2024

View reviewed changes

Merge branch 'main' into rynowak/remove-cosmos

51340e6

rynowak temporarily deployed to publish-bicep December 12, 2024 00:43 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests December 12, 2024 05:41 — with GitHub Actions Inactive

Merge branch 'main' into rynowak/remove-cosmos

c4af6a9

rynowak temporarily deployed to publish-bicep December 12, 2024 17:00 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests December 12, 2024 17:00 — with GitHub Actions Inactive

rynowak merged commit 9b87685 into radius-project:main Dec 12, 2024
29 checks passed

rynowak deleted the rynowak/remove-cosmos branch December 12, 2024 23:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove CosmosDB database provider #8116

Remove CosmosDB database provider #8116

rynowak commented Dec 10, 2024

rynowak Dec 10, 2024

codecov bot commented Dec 11, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 11, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 11, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 11, 2024 •

edited

Loading

kachawla Dec 12, 2024 •

edited

Loading

rynowak Dec 12, 2024

kachawla Dec 12, 2024

radius-functional-tests bot commented Dec 12, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 12, 2024 •

edited

Loading

Remove CosmosDB database provider #8116

Remove CosmosDB database provider #8116

Conversation

rynowak commented Dec 10, 2024

Description

Type of change

Contributor checklist

rynowak Dec 10, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 11, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Dec 11, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Dec 11, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Dec 11, 2024 • edited Loading

Radius functional test overview

Test Status

kachawla Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

rynowak Dec 12, 2024

Choose a reason for hiding this comment

kachawla Dec 12, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Dec 12, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Dec 12, 2024 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Dec 11, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 11, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 11, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 11, 2024 •

edited

Loading

kachawla Dec 12, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 12, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 12, 2024 •

edited

Loading